fixes that the config could not be loaded and an oversight in Columni…#556
Merged
Hirogen merged 2 commits intoDevelopmentfrom Mar 21, 2026
Merged
fixes that the config could not be loaded and an oversight in Columni…#556Hirogen merged 2 commits intoDevelopmentfrom
Hirogen merged 2 commits intoDevelopmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces targeted improvements to the columnizer configuration system, focusing on clarifying interface usage and ensuring configuration objects are properly initialized. The main changes update interface references to the more specific
IColumnizerConfiguratorMemoryand add a safeguard for configuration initialization in the regex columnizer.Columnizer configuration interface updates:
IColumnizerConfiguratortoIColumnizerConfiguratorMemoryin both the summary documentation and the type check when cloning columnizers, ensuring the correct interface is used for memory-based columnizer configuration. [1] [2]Configuration initialization improvement:
RegexColumnizer, added logic to initialize_configwith a default configuration if it is null before displaying the configuration dialog, preventing potential null reference issues.